Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging main into rearchitecture #239

Closed
wants to merge 163 commits into from

Conversation

SamuelHall700
Copy link
Collaborator

PolarRoute Pull Request Template

Date:
Version Number:

Description of change

Fixes # (issue)

Testing

To ensure that the functionality of the PolarRoute codebase remains consistent throughout the development cycle a testing strategy has been developed, which can be viewed in the document test/testing_strategy.md.
This includes a collection of test files which should be run according to which part of the codebase has been altered in a pull request. Please consult the testing strategy to determine which tests need to be run.

  • My changes have not altered any of the files listed in the testing strategy

  • My changes result in all required regression tests passing without the need to update test files.

list which files have been altered and include a pytest.txt file for each of
the tests required to be run

The files which have been changed during this PR can be listed using the command

git diff --name-only 0.3.x
  • My changes require one or more test files to be updated for all regression tests to pass.

include pytest.txt file showing which tests fail.
include reasoning as to why your changes cause these tests to fail.

Should these changes be valid, relevant test files should be updated.
include pytest.txt file of test passing after test files have been updated.

Checklist

  • My code follows pep8 style guidelines.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation of the codebase where required.
  • My changes generate no new warnings.
  • My PR has been made to the 0.3.x branch (DO NOT SUBMIT A PR TO MAIN)

gecoombs and others added 30 commits June 7, 2023 14:42
Better splitting conditions explanation and example fix
hjabbot and others added 29 commits September 21, 2023 16:37
Exclusion zone vessel performance
Add in total traveltime and fuel properties to route output
updating references to cartographi to meshiphi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants